Skip to content

Conversation

@annadoesdesign
Copy link
Contributor

This was missing from v2, but in v1; I dont think it ever made it over:

Before:
Screenshot 2025-11-07 at 1 33 46 PM
Screenshot 2025-11-07 at 1 33 58 PM

After:
Screenshot 2025-11-07 at 1 33 17 PM

Screen.Recording.2025-11-07.at.1.31.47.PM.mov

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 7, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Bundle Report

Changes will increase total bundle size by 598 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.64MB 598 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 598 bytes 19.01MB 0.0%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/EntityDropdown/EntityDropdown.tsx → Total Size: 14.06kB

  • ./src/app/entityV2/glossaryNode/GlossaryNodeEntity.tsx → Total Size: 4.34kB

  • ./src/app/entityV2/shared/EntityDropdown/EntityMenuActions.tsx → Total Size: 3.74kB

  • ./src/app/entityV2/shared/EntityDropdown/CreateGlossaryEntityModal.tsx → Total Size: 8.46kB

  • ./src/app/entityV2/glossaryTerm/GlossaryTermEntity.tsx → Total Size: 5.5kB

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 7, 2025

✅ Meticulous spotted 0 visual differences across 1015 screens tested: view results.

Meticulous evaluated ~9 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit d99ccc8. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! suggestion on updating the name here to have (copy) in the name by default otherwise we throw errors if they create a term with the same name at the same level

Comment on lines 67 to 69
setStagedName(properties.name);
form.setFieldValue('name', properties.name);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about doing ${properties.name} (copy) here? for both of these setters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uupdated to this!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 10, 2025
@github-actions github-actions bot requested a deployment to datahub-project-web-react (Preview) November 18, 2025 15:53 Abandoned
@annadoesdesign annadoesdesign merged commit fded33c into master Nov 20, 2025
47 of 48 checks passed
@annadoesdesign annadoesdesign deleted the ae--DES-447-add-clone-to-menu branch November 20, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants